[Service Runner] Search for Jump List Actions
ClosedPublic
Actions

Authored by broulik on Apr 27 2016, 10:04 PM.

Details

Reviewers

Group Reviewers

Plasma: Design
Plasma

Commits

R871:00593d47e060: [Service Runner] Search for Jump List Actions
R120:00593d47e060: [Service Runner] Search for Jump List Actions

Summary

This makes the service runner find also additional actions provided by applications,
eg. "big picture" now finds Steam's "Big Picture" mode which isn't a separate application
service but instead an action on the main application.

Test Plan

I also find "open new incognito tab" actions or "take rectangular region screenshot" when I search for the right term.

What's a bit amsing is that searching for "tab" (German localization) finds "LibreOffice DaTABase" as topmost result (the LibreOffice welcome thing has all the LibreOffice apps as additional actions, in addition to the separate launcher entries) with Chrome and KCharselect as next results

Since I cannot really query for the actions directly, I wanted to at least limit it to services that have Actions but KServiceTypeTrader doesn't the "Actions" key apparently

Diff Detail

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik updated this revision to Diff 3551.Apr 27 2016, 10:04 PM

broulik retitled this revision from to [Service Runner] Search for Jump List Actions.

broulik updated this object.

broulik edited the test plan for this revision. (Show Details)

broulik added reviewers: Plasma, Plasma: Design.

broulik set the repository for this revision to R120 Plasma Workspace.

broulik added a project: Plasma.

Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptApr 27 2016, 10:04 PM

+1 from the usability side

mart accepted this revision.Apr 28 2016, 9:00 AM

mart added a reviewer: mart.

mart added a subscriber: mart.

mart added inline comments.

runners/services/servicerunner.cpp
266	is this context enough? it seems to imply this is always about web browser, wouldn't be better saying explicitly "this is about jump list actions for instance for a web browser open new tab - browser name"

This revision is now accepted and ready to land.Apr 28 2016, 9:00 AM

Closed by commit R120:00593d47e060: [Service Runner] Search for Jump List Actions (authored by broulik). · Explain WhyApr 30 2016, 11:36 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			runners/services/servicerunner.cpp (49 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	3551			Apr 27 2016, 10:00 PM	★	★
Diff 2	3571	0050652	rPLASMAWORKSPACE00593d47e0604d30926b7bb2113f2db7e4e4018c	Apr 30 2016, 11:35 AM	★	★

Diff 3571

View Options

runners/services/servicerunner.cpp