Differential D1501

[autotest] Work around "cannot assign undefined" warning
ClosedPublic
Actions

Authored by graesslin on Apr 27 2016, 9:03 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R135:024a79f12649: [autotest] Work around "cannot assign undefined" warning
Summary

If both tests cases in the qml file dialog test are run together, there
is a warning:
file:///opt/qt5/qml/QtQuick/Controls/TextField.qml:638:28: Unable to assign [undefined] to QString

This seems to be caused by destroying the QQmlEngine. Thus this change
keeps one QQmlEngine around and also changes the memory management in
other areas. The ownership of a created component is passed to the
caller, thus it needs to be in a QScopedPointer.

Note: this test asserts on build.kde.org. I'm not able to reproduce the
assert locally, but I think it might be related to this warning.

Diff Detail

Repository
R135 Integration for Qt applications in Plasma
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 3535.Apr 27 2016, 9:03 AM
graesslin retitled this revision from to [autotest] Work around "cannot assign undefined" warning.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptApr 27 2016, 9:03 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
graesslin updated this revision to Diff 3536.Apr 27 2016, 9:08 AM

Add back code deleted by accident

mart accepted this revision.Apr 27 2016, 9:09 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Apr 27 2016, 9:09 AM
Closed by commit R135:024a79f12649: [autotest] Work around "cannot assign undefined" warning (authored by graesslin). · Explain WhyApr 27 2016, 9:29 AM
This revision was automatically updated to reflect the committed changes.
bshah added a subscriber: bshah.Apr 27 2016, 10:45 AM

This should also be backported to framewokintegration.

Revision Contents
Changeset List

Diff 3537

View Options

autotests/kfiledialogqml_unittest.cpp

Loading...