Differential D14989

Implement option to toggle desktop navigation wraps around for desktop switching using mouse action
Needs ReviewPublic
Actions

Authored by phuongn on Aug 22 2018, 8:12 AM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

BUG: 361672

This patch implement an option to disable navigation wraps around for the switch desktop mouse action, which potentially cause inconveniences for user who switch desktop using mouse wheel or touchpad scroll on the desktop.

The patch is implemented since "Desktop navigation wraps around" option in "System Settings -> Desktop Behavior -> Virtual Desktops -> Switching" only affects keyboard shortcut mapping.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
phuongn created this revision.Aug 22 2018, 8:12 AM
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptAug 22 2018, 8:12 AM
phuongn requested review of this revision.Aug 22 2018, 8:12 AM
phuongn updated this revision to Diff 40555.Aug 28 2018, 1:58 PM

Use standard min max functions to make code more readable for desktopswitch no-wrap option

phuongn updated this revision to Diff 40619.Aug 29 2018, 6:43 AM

Correct the erroneous logic for determining the next and previous desktop index

abetts added a subscriber: abetts.Aug 29 2018, 2:41 PM

Just a nitpick: Since we have a checkbox and then a label, can the label also have the word "Enable". We have transitioned into making actionable checkboxes to start their label with an active verb.

phuongn updated this revision to Diff 40791.Aug 31 2018, 8:52 PM

Ok! I updated the string, it's now "Enable desktop navigation wraps around"

ngraham added a subscriber: ngraham.Aug 31 2018, 8:58 PM
In D14989#318428, @phuongn wrote:

Ok! I updated the string, it's now "Enable desktop navigation wraps around"

Hmm, now that's no longer grammatically correct. How about: "Enable virtual desktop navigation wrapping"

abetts added a comment.Aug 31 2018, 8:59 PM

I like that string better.

phuongn updated this revision to Diff 40792.Aug 31 2018, 9:06 PM

Agree! Updated 🙂

Showing Only Differences

This revision modifies 4 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Diff 40792

View Options

containmentactions/switchdesktop/config.ui

Loading...