Differential D1498

Fix memory leak in system tray
ClosedPublic
Actions

Authored by davidedmundson on Apr 26 2016, 3:57 PM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R871:d5494afe48a6: Fix memory leak in system tray
R120:d5494afe48a6: Fix memory leak in system tray
Summary

Currently we leak an IconLoader for each icon for the time the system
tray is in memory.

An app may also load icons from their own directories, so we need a new
iconloader that takes this into account

This is wrapped into a subclass of iconengine so the iconloader lifespan
matches the icon object

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 3530.Apr 26 2016, 3:57 PM
davidedmundson retitled this revision from to Fix memory leak in system tray.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptApr 26 2016, 3:57 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol accepted this revision.Apr 26 2016, 4:00 PM
apol added a reviewer: apol.
apol added a subscriber: apol.

LGTM, thanks!

This revision is now accepted and ready to land.Apr 26 2016, 4:00 PM
Closed by commit R120:d5494afe48a6: Fix memory leak in system tray (authored by davidedmundson). · Explain WhyApr 26 2016, 4:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mapplets/systemtray/systemtray.cpp (33 lines)

Diff 3531

View Options

applets/systemtray/systemtray.cpp

Loading...