Adjust library cmake check for new syntax, and fix the version check in juliaserver.cpp to use the new API with 1.0
Details
Details
Builds with julia 0.6.4, 0.7.0 and 1.0.0
Diff Detail
Diff Detail
- Repository
- R55 Cantor
- Lint
Lint Skipped - Unit
Unit Tests Skipped
src/backends/julia/juliaserver/juliaserver.cpp | ||
---|---|---|
46 ↗ | (On Diff #40102) | This can be simplified, and made it future-proof using QT_VERSION_CHECK: #if QT_VERSION_CHECK(JULIA_VERSION_MAJOR, JULIA_VERSION_MINOR, 0) >= QT_VERSION_CHECK(0, 5, 0) |
Comment Actions
Hi, @arojas
First, Thanks!
Second, I couldn't found julia 1.0.0. As I see, there are problems with JULIA_LIBDL_COMMAND: cmake drop ; symbol (I don't see the symbol in message output).
I add escaping for this symbol (\) and all start works fine.
Do you haven't problem with version 1.0.0?
Comment Actions
I don't have this issue, perhaps it depends on the cmake version. It works for me also with escaping, so I can add it to be safe.