Akonadi protocol: an invalid response is still a response.
ClosedPublic

Authored by dfaure on Aug 20 2018, 10:08 PM.

Details

Summary

The _ResponseBit wasn't set, which made some of protocoltest fail
(ever since it was initially written in 5636aaf so this isn't a regression!),
and which would even lead to a crash (detected by that test) when doing
res->isError() after serializeAndDeserialize which didn't actually create a
Response subclass...

Test Plan

protocoltest went from 3 failures to 1, the last one being the protocol version
(but given the comment next to it, I emailed Dan...)

Diff Detail

Repository
R165 Akonadi
Branch
Applications/18.08
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2046
Build 2064: arc lint + arc unit
dfaure created this revision.Aug 20 2018, 10:08 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptAug 20 2018, 10:08 PM
Restricted Application edited subscribers, added: kde-pim; removed: KDE PIM. · View Herald Transcript
dfaure requested review of this revision.Aug 20 2018, 10:08 PM
dvratil accepted this revision.Aug 21 2018, 7:50 AM
This revision is now accepted and ready to land.Aug 21 2018, 7:50 AM
dfaure closed this revision.Aug 21 2018, 8:59 AM