Differential D1492

Register Marble app, part & thumbnailer for application/vnd.geo+json
ClosedPublic
Actions

Authored by kossebau on Apr 25 2016, 5:55 PM.

Details

Reviewers
nienhueser
rahn
Commits
R34:a13c14a1ef15: Register Marble app, part & thumbnailer for application/vnd.geo+json
Summary

Don't be shy, tell the system that Marble has a plugin for handling geojson
:)

Test Plan

Created a sample file with the example from en.wikipedia.org/wiki/GeoJSON
My shared-mime-info has application/vnd.geo+json already (added in Oct
2015). Installing with the patch and triggering kbuildsycoca5, Marble is
called as handler when clicking on the sample file in Dlphin as well as does
the thumbnailer show a preview (need enabling in Dolphin settings as usual)

Diff Detail

Repository
R34 Marble
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau updated this revision to Diff 3517.Apr 25 2016, 5:55 PM
kossebau retitled this revision from to Register Marble app, part & thumbnailer for application/vnd.geo+json.
kossebau updated this object.
kossebau edited the test plan for this revision. (Show Details)
kossebau added reviewers: rahn, nienhueser.
nienhueser accepted this revision.Apr 27 2016, 4:13 AM
nienhueser edited edge metadata.

Looks good.

src/plugins/runner/json/marble_thumbnail_geojson.desktop
4

Maybe geographical instead of geospatial?

This revision is now accepted and ready to land.Apr 27 2016, 4:13 AM
kossebau added inline comments.Apr 27 2016, 4:28 PM
src/plugins/runner/json/marble_thumbnail_geojson.desktop
4

Yes, sounds better, changed to that.
Took the intial name from shared-mime-info, but have to agree that geographical is both in line with names for gpx & kml as well seems more common.

Closed by commit R34:a13c14a1ef15: Register Marble app, part & thumbnailer for application/vnd.geo+json (authored by kossebau). · Explain WhyApr 27 2016, 4:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 3544

View Options

src/plugins/runner/json/CMakeLists.txt

Loading...
View Options

src/plugins/runner/json/marble_geojson.desktop

Loading...
View Options

src/plugins/runner/json/marble_part_geojson.desktop

Loading...
View Options

src/plugins/runner/json/marble_thumbnail_geojson.desktop

Loading...