Details
Details
- Reviewers
boemann danders - Group Reviewers
Calligra: 3.0 - Commits
- R8:f5a88ba9040e: [ArtisticTextShape] Merge text ranges with same style
Diff Detail
Diff Detail
- Repository
- R8 Calligra
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
The change in appendText(const QString &text):
The original appended to an existing range while you add a new range.
I would think you could just leave the old code untouched, no?
Comment Actions
Basically we want to be unchanged, but when it merged, now, it does not have guaranteed that appending to last will be nor same behavior nor correct.
Comment Actions
Hmm, I assumed it only got in here when appending a text to
a) an empty shape (no need for merging),
b) at the end of an existing text, in which case using the the existing formatting of the last range should ok. I just can't see why using a defaultfont in this case is correct.
What have I missed?
Comment Actions
You are right, when i see docs
/// Appends plain text to the last text range
void appendText(const QString &plainText);