Differential D1487

Don't depend on operation mode in WindowPixmap
ClosedPublic
Actions

Authored by graesslin on Apr 25 2016, 8:55 AM.

Details

Reviewers
sebas
mart
Group Reviewers
Plasma
Commits
R108:ac1a8a014259: Don't depend on operation mode in WindowPixmap
Summary

To check which code path we should take just check whether

  • we have a surface -> Wayland
  • we have a pixmap -> X11

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 3506.Apr 25 2016, 8:55 AM
graesslin retitled this revision from to Don't depend on operation mode in WindowPixmap.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptApr 25 2016, 8:55 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Apr 28 2016, 9:16 AM
mart added a reviewer: mart.
mart added a subscriber: mart.

even in my unexpertness of kwin, it makes sense to me tough

This revision is now accepted and ready to land.Apr 28 2016, 9:16 AM
sebas accepted this revision.May 2 2016, 1:07 PM
sebas added a reviewer: sebas.
sebas added a subscriber: sebas.

Looks sensible.

Closed by commit R108:ac1a8a014259: Don't depend on operation mode in WindowPixmap (authored by graesslin). · Explain WhyMay 2 2016, 2:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mscene.cpp (8 lines)

Diff 3605

View Options

scene.cpp

Loading...