Differential D14859

Don't try to call transaction documentUrl with a 0 id
Needs ReviewPublic
Actions

Authored by jtamate on Aug 15 2018, 10:17 AM.

Details

Reviewers
pino
Group Reviewers
Frameworks
Summary

In Transaction::documentUrl(quint64 id) const, there is
Q_ASSERT(id > 0);
so don't even try to call it with a 0 id.

Test Plan

Executing balooshow -i /home/user/* when baloo is creating the index after deleting .local/share/baloo
before: crash (assert)
after: balooshow ends normally.

Diff Detail

Repository
R293 Baloo
Lint
Lint Skipped
Unit
Unit Tests Skipped
jtamate created this revision.Aug 15 2018, 10:17 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptAug 15 2018, 10:17 AM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
jtamate requested review of this revision.Aug 15 2018, 10:17 AM
pino requested changes to this revision.Aug 15 2018, 10:27 AM
pino added a subscriber: pino.
pino added inline comments.
src/tools/balooshow/main.cpp
140–145

maybe fid > 0 for clarity

143

string puzzle, please use placeholders for i18n()

This revision now requires changes to proceed.Aug 15 2018, 10:27 AM
jtamate updated this revision to Diff 39788.Aug 15 2018, 10:43 AM

Done requested changes.

Revision Contents
Changeset List

PathPackages
Msrc/tools/balooshow/main.cpp (7 lines)

Diff 39788

View Options

src/tools/balooshow/main.cpp

Loading...