Differential D14841

Add booking.com unstrucured data extractor (french)
ClosedPublic
Actions

Authored by bport on Aug 14 2018, 3:34 PM.

Details

Reviewers
vkrause
mlaurent
Commits
R1003:36bd73a12e54: Add booking.com unstrucured data extractor (french)

Diff Detail

Repository
R1003 KItinerary: Travel Reservation handling library
Branch
booking_extractor
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1839
Build 1857: arc lint + arc unit
bport created this revision.Aug 14 2018, 3:34 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptAug 14 2018, 3:34 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
bport requested review of this revision.Aug 14 2018, 3:34 PM
mlaurent added inline comments.Aug 14 2018, 3:52 PM
src/extractors/booking.js
43

You can remove it.

45

you return even if it can be another locale ?

61

same here

78

same

mlaurent requested changes to this revision.Aug 14 2018, 3:52 PM
This revision now requires changes to proceed.Aug 14 2018, 3:52 PM
mlaurent added inline comments.Aug 14 2018, 4:00 PM
src/extractors/booking.js
45

Ah no you already did it here:

var bookingRef = text.match(regExMap[locale]['bookingRef']);
// If no booking reference go to the next locale
if (!bookingRef)
    continue;

ok.

bport updated this revision to Diff 39735.Aug 14 2018, 4:18 PM
  • Remove uneeded debug
vkrause accepted this revision.Aug 14 2018, 8:18 PM

Thank you!

bport updated this revision to Diff 39751.Aug 14 2018, 8:45 PM
  • Add english support for booking.com
vkrause accepted this revision.Aug 14 2018, 9:14 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 16 2018, 8:27 AM
Closed by commit R1003:36bd73a12e54: Add booking.com unstrucured data extractor (french) (authored by bport). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 39724

View Options

src/extractors/booking.js

Loading...
View Options

src/extractors/booking.json

Loading...
View Options

src/extractors/extractors.qrc

Loading...