Select current format on the configure backend dialog
ClosedPublic

Authored by aacid on Aug 14 2018, 8:57 AM.

Diff Detail

Repository
R223 Okular
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aacid created this revision.Aug 14 2018, 8:57 AM
Restricted Application added a project: Okular. · View Herald TranscriptAug 14 2018, 8:57 AM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
aacid requested review of this revision.Aug 14 2018, 8:57 AM
sander added a subscriber: sander.Aug 14 2018, 11:15 AM

Looking good! Concerning the preparatory commit 9ba8dd2cd7838c626af79a4edcd8b8437205cc02 , which copies the list of loaded generators from a QHash to a QMap: Why not use a QMap for them right away? Certainly the number of generators is low enough such that the efficiency differences between a QHash and a QMap become negligible?

Looking good! Concerning the preparatory commit 9ba8dd2cd7838c626af79a4edcd8b8437205cc02 , which copies the list of loaded generators from a QHash to a QMap: Why not use a QMap for them right away? Certainly the number of generators is low enough such that the efficiency differences between a QHash and a QMap become negligible?

Yes, there is some copying, but it's faster than you blinking so let's not worry about that.

I also thought about changing the hash to map, should have not implications, but yeah prefered to limit changes only to that same function.

Fine with me. If you want I can post a separate QHash -> QMap cleanup patch. Either way, for me this patch can land in git.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 8 2018, 8:54 PM
This revision was automatically updated to reflect the committed changes.