Details
Details
- Reviewers
- None
- Commits
- R223:a482c56ba240: Select current format on the configure backend dialog
Diff Detail
Diff Detail
- Repository
- R223 Okular
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Looking good! Concerning the preparatory commit 9ba8dd2cd7838c626af79a4edcd8b8437205cc02 , which copies the list of loaded generators from a QHash to a QMap: Why not use a QMap for them right away? Certainly the number of generators is low enough such that the efficiency differences between a QHash and a QMap become negligible?
Comment Actions
Yes, there is some copying, but it's faster than you blinking so let's not worry about that.
I also thought about changing the hash to map, should have not implications, but yeah prefered to limit changes only to that same function.
Comment Actions
Fine with me. If you want I can post a separate QHash -> QMap cleanup patch. Either way, for me this patch can land in git.