Make 'configure generators' dialog open with current generator selected
AbandonedPublic
Actions

Authored by sander on Aug 13 2018, 8:58 PM.

Details

Reviewers

None

Group Reviewers

Summary

The 'current generators' dialog has a page for each generator. The choice of which of these pages is visible when the dialog is first opened seems to be random (or at least I don't see the pattern). This patch makes sure that the currently running generator determines which page is opened, because in most cases people will want to set preferences for the generator they are currently using.

Unfortunately, I had to change the interface of Okular::ConfigInterface for this. Speak up if you know a better way.

Test Plan

Open Okular with a pdf file
Open Settings -> Configure Backends
Notice how the dialog opens with the pdf settings right away
Open (e.g.) a markdown file
Open Settings -> Configure Backends
Notice how the dialog opens with the markdown settings right away

Diff Detail

Repository

R223 Okular

Lint

Lint Skipped

Unit

Unit Tests Skipped

sander created this revision.Aug 13 2018, 8:58 PM

Restricted Application added a project: Okular. · View Herald TranscriptAug 13 2018, 8:58 PM

Restricted Application added a subscriber: okular-devel. · View Herald Transcript

sander requested review of this revision.Aug 13 2018, 8:58 PM

I made https://phabricator.kde.org/D14820 (you need latest branch since i did a change to make the sorting at least stable in the config dialog) which doesn't need changing the API, which i think it's better since it won't break plugins that may exist outside the okular repository.

Can you give it a look/try?

I tested https://phabricator.kde.org/D14820 and it works nicely. Thanks for your effort! I also like the fact that the entries get sorted now.

sander abandoned this revision.Aug 14 2018, 9:54 AM

Revision Contents
Changeset List

			Path	Packages
M			core/document.cpp (7 lines)
M			core/textdocumentgenerator.h (2 lines)
M			core/textdocumentgenerator.cpp (4 lines)
M			generators/fictionbook/generator_fb.h (2 lines)
M			generators/fictionbook/generator_fb.cpp (4 lines)
M			generators/markdown/generator_md.h (2 lines)
M			generators/markdown/generator_md.cpp (4 lines)
M			generators/ooo/generator_ooo.h (2 lines)
M			generators/ooo/generator_ooo.cpp (4 lines)
M			generators/poppler/generator_pdf.h (2 lines)
M			generators/poppler/generator_pdf.cpp (4 lines)
M			generators/txt/generator_txt.h (2 lines)
M			generators/txt/generator_txt.cpp (4 lines)
M			interfaces/configinterface.h (3 lines)