Use non-deprecated version of KRun::runUrl() in modified-on-disk dialog
ClosedPublic

Authored by sars on Aug 13 2018, 6:28 PM.

Details

Test Plan

Open a document, edit with another instance and view the diff when the modified-on-disk dialog pops up and check that it works.

Diff Detail

Repository
R40 Kate
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sars created this revision.Aug 13 2018, 6:28 PM
Restricted Application added a project: Kate. · View Herald TranscriptAug 13 2018, 6:28 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
sars requested review of this revision.Aug 13 2018, 6:28 PM
pino added a subscriber: pino.Aug 13 2018, 6:43 PM

Note that kate requires Frameworks 5.13.0 (see KF5_DEP_VERSION in CMakeLists.txt), and the new KRun::runUrl with flags was introduced in KIO 5.31.
So, unless the dependency bump is wanted, you need to add a #ifdef block to use the new function only with KIO >= 5.31.

...which raises the question of the minimum required Frameworks version needed by the KDE Application release.

Unfortunately I can't find this info on any of our announcements or wiki pages...

This revision was not accepted when it landed; it landed in state Needs Review.Aug 14 2018, 10:00 AM
This revision was automatically updated to reflect the committed changes.