Differential D14751

[Shell Corona] Don't create ScriptingEngine if there are no update scripts
ClosedPublic
Actions

Authored by broulik on Aug 11 2018, 9:12 PM.

Details

Reviewers
mart
davidedmundson
Group Reviewers
Plasma
Commits
R120:f326b1435a71: [Shell Corona] Don't create ScriptingEngine if there are no update scripts
Summary

It takes almost 30ms here to create the engine and then we usually don't end up using it as all update scripts had already been processed in the past.

Test Plan
  • Update script is still processed if not in "performed" list

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Aug 11 2018, 9:12 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 11 2018, 9:12 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Aug 11 2018, 9:12 PM
davidedmundson accepted this revision.Aug 11 2018, 9:38 PM
This revision is now accepted and ready to land.Aug 11 2018, 9:38 PM
Closed by commit R120:f326b1435a71: [Shell Corona] Don't create ScriptingEngine if there are no update scripts (authored by broulik). · Explain WhyAug 11 2018, 10:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mshell/shellcorona.cpp (8 lines)

Diff 39478

View Options

shell/shellcorona.cpp

Loading...