Differential D14747

[Exe Thumbnailer] Don't generate QTemporaryFile
ClosedPublic
Actions

Authored by broulik on Aug 11 2018, 4:16 PM.

Details

Reviewers
vonreth
Group Reviewers
Frameworks
Windows
Commits
R320:378df6f6eebe: [Exe Thumbnailer] Don't generate QTemporaryFile
Summary

Keep everything in memory and don't needlessly write to disk

Test Plan
  • Thumbnails still generate just fine
  • Doesn't create files in /tmp anymore
  • Compiled but untested on Windows

Diff Detail

Repository
R320 KIO Extras
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik requested review of this revision.Aug 11 2018, 4:16 PM
broulik created this revision.
broulik updated this revision to Diff 40205.Aug 22 2018, 10:33 AM
broulik edited the test plan for this revision. (Show Details)
  • Fix build on Windows
broulik updated this revision to Diff 40207.Aug 22 2018, 10:34 AM
  • Fix diff
This revision was not accepted when it landed; it landed in state Needs Review.Aug 30 2018, 10:34 AM
Closed by commit R320:378df6f6eebe: [Exe Thumbnailer] Don't generate QTemporaryFile (authored by broulik). · Explain Why
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 4 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 40207