Settle on var names ANDROID_SDK_ROOT/ANDROID_NDK_ROOT
ClosedPublic
Actions

Authored by kossebau on Apr 23 2016, 10:16 PM.

Details

Reviewers

nienhueser
rahn

Commits

R34:e00e8c40d4fb: Settle on var names ANDROID_SDK_ROOT/ANDROID_NDK_ROOT

Summary

Motivated by https://mail.kde.org/pipermail/kde-android/2016-April/000048.html

Would update wiki page, once committed.

Diff Detail

Repository

R34 Marble

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kossebau updated this revision to Diff 3487.Apr 23 2016, 10:16 PM

kossebau retitled this revision from to Settle on var names ANDROID_SDK_ROOT/ANDROID_NDK_ROOT.

kossebau updated this object.

kossebau edited the test plan for this revision. (Show Details)

kossebau added reviewers: nienhueser, rahn.

kossebau added projects: Marble, Android.Apr 24 2016, 2:34 PM

Given that the number of people using the deploy scripts is rather small I'm fine with changing this without much deprecation logic behind. Thanks for taking this on.

This revision is now accepted and ready to land.Apr 24 2016, 2:46 PM

Closed by commit R34:e00e8c40d4fb: Settle on var names ANDROID_SDK_ROOT/ANDROID_NDK_ROOT (authored by kossebau). · Explain WhyApr 24 2016, 4:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/apps/behaim/CMakeLists.txt (4 lines)
M			src/apps/behaim/package/deploy-behaim.json.in (4 lines)
M			src/apps/marble-maps/CMakeLists.txt (4 lines)
M			src/apps/marble-maps/package/deploy-marble-maps.json.in (4 lines)