Differential D14704

Don't define WebEnginePartCookieJar::filterCookie for old versions of Qt
ClosedPublic
Actions

Authored by stefanocrocco on Aug 9 2018, 10:03 AM.

Details

Reviewers
dfaure
Commits
R226:eed46bd49aec: Don't define WebEnginePartCookieJar::filterCookie for old versions of Qt
Summary

for versions of Qt before 5.11, WebEnginePartCookieJar::filterCookie
can't be defined because it's argument is of a type introduced in Qt 5.11.0

Test Plan

I couldn't test whether this actually builds on older versions of Qt because my systems all have Qt 5.11

Diff Detail

Repository
R226 Konqueror
Branch
fix-cookies-5.9
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1635
Build 1653: arc lint + arc unit
stefanocrocco requested review of this revision.Aug 9 2018, 10:03 AM
stefanocrocco created this revision.
dfaure accepted this revision.Aug 9 2018, 10:04 AM
This revision is now accepted and ready to land.Aug 9 2018, 10:04 AM
stefanocrocco edited the test plan for this revision. (Show Details)Aug 9 2018, 10:05 AM
Closed by commit R226:eed46bd49aec: Don't define WebEnginePartCookieJar::filterCookie for old versions of Qt (authored by stefanocrocco). · Explain WhyAug 9 2018, 10:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 39338

View Options

webenginepart/src/webenginepartcookiejar.h

Loading...
View Options

webenginepart/src/webenginepartcookiejar.cpp

Loading...