Maybe this has been discussed before, but I think something like a magnifying glass (search) would be more appropriate. The check mark suggests that the code is "verified", in the sense that it's definitely fine, but most (all?) static analysis tools don't guarantee that. If the tool finds something, then something is probably wrong, but if it doesn't, there could still be a mistake.
The tools also get better, adding more checks, which means that there might be no issues with some code first, but on updating the analysis tool new issues appear. Then it's weird to have the check mark, because once "it worked" and now "it doesn't". With the magnifying glass it's clear that we search for issues, and with new versions of our tool we might find more.
I am also not happy with the abuse of the "dialog-ok" icon. Though currently from the existing icons in the Breeze (and Oxygen) icon sets I would favour it over the "search" icons for these reasons:
- it is unique in its use, one cannot mix it up with the search actions when scanning the menus and toolbars just by icons
- the checkmark symbol used in the icons in both icon sets still is semantically close enough to "checking something". Cmp. also the logo of Cppcheck, which contains a checkmark as well.
I would have filed a request with the KDE icon designers for a new dedicated icon for "Analyze" reflecting the process and its open result nature, but seems there is currently no-one around or interested enough in work for kdevelop icons ( see old requests https://bugs.kde.org/show_bug.cgi?id=376248, https://bugs.kde.org/show_bug.cgi?id=379349), so I have not yet looked into that direction :(
Perhaps someone with more energy left for this (and/or better social skils :) ) could get in contact with the icon designers again now.
That argument make sense. Maybe a magnifying glass with a bug inside would be the best thing, but as you pointed out in the bug report, we don't even have a good icon for starting debugging yet.