Differential D14672

[plasma-changeicons] Call sync() after writing
ClosedPublic
Actions

Authored by broulik on Aug 7 2018, 2:25 PM.

Details

Reviewers
davidedmundson
mart
Group Reviewers
Plasma
Commits
R119:716deea83dae: [plasma-changeicons] Call sync() after writing
Summary

Plasma-integration's KHintsSettings keeps kdeglobals open, so we need to explicitly sync() before we go through the process of telling everything it's changed

Test Plan

Changing icons in the KCM affects everything some things more immediately now. It's still borked in many places for some reason :/

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Aug 7 2018, 2:25 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 7 2018, 2:25 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Aug 7 2018, 2:25 PM
broulik edited the test plan for this revision. (Show Details)Aug 7 2018, 2:39 PM
mart accepted this revision.Aug 12 2018, 2:51 PM
This revision is now accepted and ready to land.Aug 12 2018, 2:51 PM
Closed by commit R119:716deea83dae: [plasma-changeicons] Call sync() after writing (authored by broulik). · Explain WhyAug 23 2018, 1:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcms/icons/changeicons.cpp (1 line)

Diff 40301

View Options

kcms/icons/changeicons.cpp

Loading...