Differential D14660

Krita's work scheduler internal lock fixes
ClosedPublic
Actions

Authored by lieroz on Aug 6 2018, 6:09 PM.

Details

Reviewers
dkazakov
rempt
Group Reviewers
Krita
Summary

Changed qt signals for simple function calls to avoid mutexes in qt's signals implementation.

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
lieroz created this revision.Aug 6 2018, 6:09 PM
Restricted Application added a reviewer: Krita. · View Herald TranscriptAug 6 2018, 6:09 PM
lieroz requested review of this revision.Aug 6 2018, 6:09 PM
dkazakov accepted this revision.Aug 7 2018, 3:20 PM

The patch looks and works perfectly fine! Please push!

Btw, does this change make any measurable difference in a benchmark?

This revision is now accepted and ready to land.Aug 7 2018, 3:20 PM
lieroz added a comment.Aug 7 2018, 4:11 PM

Thanks. No it doesn't, maybe 1% better, no more, cause threads just wait on other places.

Revision Contents
Changeset List

Diff 39217

View Options

libs/image/kis_update_job_item.h

Loading...
View Options

libs/image/kis_update_scheduler.h

Loading...
View Options

libs/image/kis_update_scheduler.cpp

Loading...
View Options

libs/image/kis_updater_context.h

Loading...
View Options

libs/image/kis_updater_context.cpp

Loading...