[Notifications Engine] Guard "this"
ClosedPublic
Actions

Authored by broulik on Aug 6 2018, 2:05 PM.

Details

Reviewers

davidedmundson
jgrulich

Group Reviewers

Plasma

Commits

R120:7a98c7d5e58a: [Notifications Engine] Guard "this"

Summary

On teardown with the popup expanded, the cleanup handler might fire with us already having been deleted.

BUG: 397105
FIXED-IN: 5.12.7

Test Plan

plasmawindowed org.kde.plasma.networkmanagement no longer crashes on quit
Verified that NotificationInhibiton is still properly cleaned up when closing the popup in normal use (only after the GC kicks in, though)

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

broulik requested review of this revision.Aug 6 2018, 2:05 PM

I can no longer reproduce the crash from bug 397105.

This revision is now accepted and ready to land.Aug 6 2018, 2:13 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			dataengines/notifications/notificationsengine.cpp (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	39195			Aug 6 2018, 1:50 PM	★	★
Diff 2	39245	cf7381d	R120:7a98c7d5e58a3afef1f85eafa92aed5ce1f30de9	Aug 7 2018, 9:45 AM	★	★