Differential D14618

Create action to jump to the current execution line in debug mode.
ClosedPublic
Actions

Authored by amhndu on Aug 5 2018, 4:56 AM.

Details

Reviewers
brauch
Group Reviewers
KDevelop
Commits
R32:59d823957de8: Create action to jump to the current execution line in debug mode.
Summary

Added new action called "Show Current Line" that will jump to the
execution position of the debugging program. This allows setting a
shortcut to it, while the previous workaround of clicking on the active
frame in the frame stack didn't.

FEATURE: 361411

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
amhndu created this revision.Aug 5 2018, 4:56 AM
Restricted Application added a project: KDevelop. · View Herald TranscriptAug 5 2018, 4:56 AM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
amhndu requested review of this revision.Aug 5 2018, 4:56 AM
amhndu added a comment.Aug 5 2018, 5:15 AM

It's overflowing the Run menu (on my resolution), should I perhaps move it somewhere else or is this acceptable ?
Screenshot: https://i.imgur.com/a2DPWtr.png

brauch accepted this revision.Aug 12 2018, 2:18 PM
brauch added a subscriber: brauch.

This looks good to me, feel free to submit it (can you?). Thanks!

This revision is now accepted and ready to land.Aug 12 2018, 2:18 PM
amhndu added a comment.Aug 12 2018, 2:20 PM

I don't think I can.

brauch added a comment.Aug 12 2018, 2:21 PM

Ok, I'll submit it later today then.

kossebau added a subscriber: kossebau.EditedSep 13 2018, 10:40 AM

This one has not yet landed, right?

@amhndu Given you are coming with all the good patches, please consider applying for KDE developer account, so you can land your patches yourself :) See https://community.kde.org/Infrastructure/Get_a_Developer_Account for instructions.

kdevplatform/shell/debugcontroller.cpp
557

const auto location, please

559

{ on same line as the if, please

561

const auto localLocation, please (auto for consistency with above)

amhndu updated this revision to Diff 41538.Sep 13 2018, 12:11 PM

Updating to adhere to the style suggestions.

amhndu marked 3 inline comments as done.Sep 13 2018, 12:12 PM
kossebau added a comment.Sep 15 2018, 8:30 AM

@amhndu Time to apply your new KDE developer account abilities :)

With this patch accepted, you can now land it. https://community.kde.org/Infrastructure/Phabricator#Step_3:_Land_your_diff should give a guide. Where unsure, someone on #kdevelop or #kde-devel should be able to help out.

This patch here should land on master, given 5.3 branch is now in feature freeze and string freeze.

Closed by commit R32:59d823957de8: Create action to jump to the current execution line in debug mode. (authored by amhndu). · Explain WhySep 15 2018, 10:01 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 41686

View Options

kdevplatform/shell/debugcontroller.h

Loading...
View Options

kdevplatform/shell/debugcontroller.cpp

Loading...
View Options

kdevplatform/shell/debugger/kdevdebuggershellui.rc

Loading...