Differential D14612

Split Telephony and SMS plugin on Android
ClosedPublic
Actions

Authored by nicolasfella on Aug 4 2018, 8:31 PM.

Details

Reviewers
albertvaka
Group Reviewers
KDE Connect
Commits
R225:665354c5d598: Split Telephony and SMS plugin on Android
Test Plan

Get called: Notification appears as before.
Get SMS: Notification shows and it appears in SMS app after reconnect.
Write SMS from app: It shows up on the phone

Diff Detail

Repository
R225 KDE Connect - Android application
Branch
smssplit
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1520
Build 1538: arc lint + arc unit
nicolasfella created this revision.Aug 4 2018, 8:31 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptAug 4 2018, 8:31 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
nicolasfella requested review of this revision.Aug 4 2018, 8:31 PM
nicolasfella updated this revision to Diff 39088.Aug 4 2018, 8:43 PM

Fix for real

nicolasfella added a comment.Aug 4 2018, 8:45 PM

Okay arc/git, I give up. SMSPlugin is actually renamed from Telepathyplugin, so the diff is kinda confusing

albertvaka accepted this revision.Aug 8 2018, 9:20 AM
albertvaka added a subscriber: albertvaka.

It's a bit weird that blocked numbers are now configured from one plugin but affect to both. Are we going to leave it like this?

This revision is now accepted and ready to land.Aug 8 2018, 9:20 AM
nicolasfella added a comment.Aug 15 2018, 3:11 PM
In D14612#305243, @albertvaka wrote:

It's a bit weird that blocked numbers are now configured from one plugin but affect to both. Are we going to leave it like this?

We could either have the setting for both independently or move it to general settings

Closed by commit R225:665354c5d598: Split Telephony and SMS plugin on Android (authored by nicolasfella). · Explain WhyAug 15 2018, 3:12 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 4 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 39088