Differential D14612

Split Telephony and SMS plugin on Android
ClosedPublic
Actions

Authored by nicolasfella on Aug 4 2018, 8:31 PM.

Details

Reviewers

albertvaka

Group Reviewers

KDE Connect

Commits

R225:665354c5d598: Split Telephony and SMS plugin on Android

Test Plan

Get called: Notification appears as before.
Get SMS: Notification shows and it appears in SMS app after reconnect.
Write SMS from app: It shows up on the phone

Diff Detail

Repository

R225 KDE Connect - Android application

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

nicolasfella created this revision.Aug 4 2018, 8:31 PM

Restricted Application added a project: KDE Connect. · View Herald TranscriptAug 4 2018, 8:31 PM

Restricted Application added a subscriber: kdeconnect. · View Herald Transcript

nicolasfella requested review of this revision.Aug 4 2018, 8:31 PM

Harbormaster completed remote builds in B1518: Diff 39086.Aug 4 2018, 8:31 PM

fix diff

Harbormaster completed remote builds in B1519: Diff 39087.Aug 4 2018, 8:38 PM

Fix for real

Harbormaster completed remote builds in B1520: Diff 39088.Aug 4 2018, 8:43 PM

Okay arc/git, I give up. SMSPlugin is actually renamed from Telepathyplugin, so the diff is kinda confusing

It's a bit weird that blocked numbers are now configured from one plugin but affect to both. Are we going to leave it like this?

This revision is now accepted and ready to land.Aug 8 2018, 9:20 AM

In D14612#305243, @albertvaka wrote:

It's a bit weird that blocked numbers are now configured from one plugin but affect to both. Are we going to leave it like this?

We could either have the setting for both independently or move it to general settings

Closed by commit R225:665354c5d598: Split Telephony and SMS plugin on Android (authored by nicolasfella). · Explain WhyAug 15 2018, 3:12 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		src/org/kde/kdeconnect/Plugins/PluginFactory.java (5 lines)
P		src/org/kde/kdeconnect/Plugins/SMSPlugin/SMSPlugin.java (286 lines) Copied from src/org/kde/kdeconnect/Plugins/TelephonyPlugin/TelephonyPlugin.java
D	M	src/org/kde/kdeconnect/Plugins/TelepathyPlugin/TelepathyPlugin.java (99 lines)
P		src/org/kde/kdeconnect/Plugins/TelephonyPlugin/TelephonyPlugin.java (182 lines) Copied to src/org/kde/kdeconnect/Plugins/SMSPlugin/SMSPlugin.java

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	39086	877cf67		Aug 4 2018, 8:31 PM	★	★
Diff 2	39087	877cf67	fix diff	Aug 4 2018, 8:38 PM	★	★
Diff 3	39088	877cf67	Fix for real	Aug 4 2018, 8:43 PM	★	★
Diff 4	39795	f8e7422	R225:665354c5d598f4441982d95d19906f482cac624d	Aug 15 2018, 3:12 PM	★	★