It doesn't do much and can be inlined into LanDeviceLink.
TODO: Figure out why sendfiletest fails
albertvaka |
KDE Connect |
It doesn't do much and can be inlined into LanDeviceLink.
TODO: Figure out why sendfiletest fails
Receiving files still works
Lint OK |
No Unit Test Coverage |
Buildable 1562 | |
Build 1580: arc lint + arc unit |
Indeed, this can be removed.
This patch seems mergeable on its own, maybe the fix for the test can be a separate patch?
core/backends/lan/landevicelink.cpp | ||
---|---|---|
124 ↗ | (On Diff #39058) | Have you tried if removing these lines breaks something? At least useSsl is never checked for sure. Can be a good time to remove it. |
136 ↗ | (On Diff #39058) | This would be more legible if split in three lines: QString address = ...; quint16 port = ...; socket->connectToHostEncrypted(address, port, QIODevice::ReadWrite); |
Oh, you mean that sendfiletest fails now, after this change.
I thought you mean the test that was already failing before, but I see you already removed that one.
In that case it would be nice to fix it as part of the same patch :P