It doesn't do much and can be inlined into LanDeviceLink.
TODO: Figure out why sendfiletest fails
Details
Details
- Reviewers
albertvaka - Group Reviewers
KDE Connect - Commits
- R224:1d1fdf8ef5c2: [WIP] Get rid of DownloadJob
Receiving files still works
Diff Detail
Diff Detail
- Repository
- R224 KDE Connect
- Branch
- nodownloadjob
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 1504 Build 1522: arc lint + arc unit
Comment Actions
Indeed, this can be removed.
This patch seems mergeable on its own, maybe the fix for the test can be a separate patch?
| core/backends/lan/landevicelink.cpp | ||
|---|---|---|
| 124 | Have you tried if removing these lines breaks something? At least useSsl is never checked for sure. Can be a good time to remove it. | |
| 136 | This would be more legible if split in three lines: QString address = ...; quint16 port = ...; socket->connectToHostEncrypted(address, port, QIODevice::ReadWrite); | |
Comment Actions
Oh, you mean that sendfiletest fails now, after this change.
I thought you mean the test that was already failing before, but I see you already removed that one.
In that case it would be nice to fix it as part of the same patch :P