Applet: Add settings for maximal volume and volume step
ClosedPublic
Actions

Authored by drosca on Apr 21 2016, 10:16 AM.

Details

Reviewers

None

Group Reviewers

Commits

Repository

R115 Plasma Audio Volume Applet

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

drosca retitled this revision from to Applet: Add settings for maximal volume and volume step.

drosca updated this object.

drosca edited the test plan for this revision. (Show Details)

drosca added a reviewer: Plasma.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

broulik added inline comments.

applet/contents/config/config.qml
28	Perhaps the volume icon?
applet/contents/ui/ConfigGeneral.qml
36	We usually use "Maximum" instead of Maximal
44	i18n
57	i18n

Maximal -> Maximum

applet/contents/config/config.qml
28	The volume kcm (displayed under applet config) already has volume icon, so I used generic plasma icon.

This revision was automatically updated to reflect the committed changes.

		Path
A	M	applet/contents/config/config.qml (30 lines)
A	M	applet/contents/config/main.xml (17 lines)
A	M	applet/contents/ui/ConfigGeneral.qml (59 lines)
M		applet/contents/ui/main.qml (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	3443	51995ad		Apr 21 2016, 10:16 AM	★	★
Diff 2	4172	51995ad	Maximal -> Maximum	Jun 2 2016, 6:26 PM	★	★
Diff 3	4366	8a6efcb	rPLASMAPA14f6ef96779cc15324df5ff7854fdabf48a6e0da	Jun 12 2016, 9:23 PM	★	★