...by include the language name into the message
- Avoid jump to top of document when clicked
Details
Details
- Reviewers
sars - Group Reviewers
Kate - Commits
- R40:13e7510eefe2: SymbolView: Improve "Not Supported" message
Choose, e.g. some Markdown file
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
We need to use i18n() for translations. the tr() calls will not be translated by the current translation system.
i18n() is from KDE Frameworks. Have a look at this page for how to use it.
Comment Actions
Sorry that I add a new (little) feature.
Let me know if you like it and what you think about the type setting.
| addons/symbolviewer/plugin_katesymbolviewer.cpp | ||
|---|---|---|
| 362 | The type is not used anywhere else at the moment.... | |
Comment Actions
While you update the string maybe you could remove the type (-1) and the comment about it?
| addons/symbolviewer/plugin_katesymbolviewer.cpp | ||
|---|---|---|
| 363 | I just tried this one and got: Sorry, "Normal" not supported yet :) The "Normal" string will not come once we get the plain-text parser in, but I think we need a bit more explanation somehow. Maybe: File type "Normal" not supoertd yet | |
Comment Actions
I like to offer once again a two line version.
When I look at the supported, and even more the obviously not supported, languages at "Extra->Modus", ther names can be pretty long.
- Is "Sorry, not supported yet!" better english than "Sorry, not yet supported!"? I would prefer the latter, but...my english is bad
- I'm not sure if the double quotes around the name is really so nice
Comment Actions
Otherwise I'm ready to commit.
| addons/symbolviewer/plugin_katesymbolviewer.cpp | ||
|---|---|---|
| 351 ↗ | (On Diff #39035) | Yep, the double quotes around the name are not needed in this version. |