Moving a default ctor/dtor definition to the header would break ABI for exported classes, but this seems to only touch non-exported ones, so this should be fine.

This revision is now accepted and ready to land.Jul 31 2018, 7:50 AM

Yes, only private classes were changed intentionally. Public classes don't have members anyways besides the d-pointer. And the d-pointer requires a non-trivial constructor/destructor.

Closed by commit R216:e7c7184209c5: Use in-class member initialization where possible (authored by dhaumann). · Explain WhyJul 31 2018, 7:23 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/lib/context.cpp (11 lines)
M			src/lib/context_p.h (10 lines)
M			src/lib/contextswitch.cpp (10 lines)
M			src/lib/contextswitch_p.h (8 lines)
M			src/lib/definition.cpp (10 lines)
M			src/lib/definition_p.h (12 lines)
M			src/lib/format.cpp (7 lines)
M			src/lib/format_p.h (8 lines)
M			src/lib/keywordlist.cpp (9 lines)
M			src/lib/keywordlist_p.h (6 lines)
M			src/lib/matchresult.cpp (7 lines)
M			src/lib/matchresult_p.h (2 lines)
M			src/lib/repository.cpp (6 lines)
M			src/lib/repository_p.h (7 lines)
M			src/lib/rule.cpp (12 lines)
M			src/lib/rule_p.h (12 lines)
M			src/lib/state.cpp (5 lines)
M			src/lib/state_p.h (4 lines)
M			src/lib/textstyledata_p.h (14 lines)
M			src/lib/themedata.cpp (1 line)
M			src/lib/themedata_p.h (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	38808	273bfa2		Jul 30 2018, 8:33 PM	★	★
Diff 2	38872	9e3f07d	R216:e7c7184209c5b75d1d6d7ae28621ba6f299e3e48	Jul 31 2018, 7:21 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
4bce2aadb5fd	e88fd01e19aa	273bfa2d75ba	Dominik Haumann	Use in-class member initialization where possible (Show More…)	Jul 30 2018, 8:33 PM

Use in-class member initialization where possibleClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 38872

src/lib/context.cpp

src/lib/context_p.h

src/lib/contextswitch.cpp

src/lib/contextswitch_p.h

src/lib/definition.cpp

src/lib/definition_p.h

src/lib/format.cpp

src/lib/format_p.h

src/lib/keywordlist.cpp

src/lib/keywordlist_p.h

src/lib/matchresult.cpp

src/lib/matchresult_p.h

src/lib/repository.cpp

src/lib/repository_p.h

src/lib/rule.cpp

src/lib/rule_p.h

src/lib/state.cpp

src/lib/state_p.h

src/lib/textstyledata_p.h

src/lib/themedata.cpp

src/lib/themedata_p.h

Use in-class member initialization where possible
ClosedPublic
Actions

Revision Contents
Changeset List