Differential D14492

Use API style foo() or createFoo(), not getFoo()
ClosedPublic
Actions

Authored by kossebau on Jul 30 2018, 4:49 PM.

Tags

Subscribers

kfunk, kdevelop-devel

Details

Reviewers

Group Reviewers

Commits

R32:f4ec2501a59a: Use API style foo() or createFoo(), not getFoo()

Diff Detail

Repository

Branch

lessgetmethods

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 1378
Build 1396: arc lint + arc unit

kossebau created this revision.Jul 30 2018, 4:49 PM

Restricted Application added a project: KDevelop. · View Herald TranscriptJul 30 2018, 4:49 PM

Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript

kossebau requested review of this revision.Jul 30 2018, 4:49 PM

Harbormaster completed remote builds in B1378: Diff 38793.Jul 30 2018, 4:49 PM

Well, why not ;)

This revision is now accepted and ready to land.Jul 30 2018, 9:11 PM

Closed by commit R32:f4ec2501a59a: Use API style foo() or createFoo(), not getFoo() (authored by kossebau). · Explain WhyJul 30 2018, 11:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			kdevplatform/interfaces/ibuddydocumentfinder.h (2 lines)
M			kdevplatform/language/assistant/renameassistant.cpp (4 lines)
M			kdevplatform/language/duchain/duchain.cpp (2 lines)
M			kdevplatform/language/highlighting/codehighlighting.cpp (2 lines)
M			kdevplatform/language/highlighting/configurablecolors.h (2 lines)
M			kdevplatform/language/highlighting/configurablecolors.cpp (2 lines)
M			kdevplatform/outputview/outputexecutejob.cpp (11 lines)
M			kdevplatform/outputview/outputfilteringstrategies.h (2 lines)
M			kdevplatform/outputview/outputfilteringstrategies.cpp (2 lines)
M			kdevplatform/outputview/tests/test_filteringstrategy.cpp (4 lines)
M			kdevplatform/project/abstractfilemanagerplugin.cpp (6 lines)
M			kdevplatform/serialization/itemrepositoryregistry.h (2 lines)
M			kdevplatform/serialization/itemrepositoryregistry.cpp (4 lines)
M			kdevplatform/shell/documentcontroller.cpp (2 lines)
M			kdevplatform/shell/mainwindow_actions.cpp (2 lines)
M			kdevplatform/shell/openprojectdialog.cpp (6 lines)
M			kdevplatform/shell/openprojectpage.h (4 lines)
M			kdevplatform/shell/openprojectpage.cpp (4 lines)
M			kdevplatform/shell/progresswidget/progressmanager.h (4 lines)
M			kdevplatform/shell/statusbar.cpp (2 lines)
M			kdevplatform/shell/tests/test_shellbuddy.cpp (2 lines)
M			kdevplatform/sublime/mainwindow.h (2 lines)
M			kdevplatform/sublime/mainwindow.cpp (2 lines)
M			kdevplatform/util/texteditorhelpers.cpp (4 lines)
M			kdevplatform/vcs/dvcs/dvcsplugin.h (2 lines)
M			kdevplatform/vcs/vcsrevision.h (2 lines)
M			kdevplatform/vcs/vcsrevision.cpp (2 lines)
M			plugins/appwizard/projectselectionpage.h (2 lines)
M			plugins/appwizard/projectselectionpage.cpp (6 lines)
M			plugins/clang/clangsupport.h (2 lines)
M			plugins/clang/clangsupport.cpp (4 lines)
M			plugins/clang/codecompletion/completionhelper.cpp (2 lines)
M			plugins/clang/duchain/clangindex.cpp (2 lines)
M			plugins/clang/duchain/documentfinderhelpers.h (2 lines)
M			plugins/clang/duchain/documentfinderhelpers.cpp (4 lines)
M			plugins/clang/tests/test_buddies.cpp (14 lines)
M			plugins/contextbrowser/contextbrowser.cpp (6 lines)
M			plugins/custommake/makefileresolver/makefileresolver.cpp (6 lines)
M			plugins/git/gitplugin.h (2 lines)
M			plugins/git/gitplugin.cpp (2 lines)
M			plugins/git/tests/test_git.cpp (2 lines)
M			plugins/switchtobuddy/switchtobuddyplugin.cpp (4 lines)

Diff 38793

kdevplatform/interfaces/ibuddydocumentfinder.h

Loading...

kdevplatform/language/assistant/renameassistant.cpp

Loading...

kdevplatform/language/duchain/duchain.cpp

Loading...

kdevplatform/language/highlighting/codehighlighting.cpp

Loading...

kdevplatform/language/highlighting/configurablecolors.h

Loading...

kdevplatform/language/highlighting/configurablecolors.cpp

Loading...

kdevplatform/outputview/outputexecutejob.cpp

Loading...

kdevplatform/outputview/outputfilteringstrategies.h

Loading...

kdevplatform/outputview/outputfilteringstrategies.cpp

Loading...

kdevplatform/outputview/tests/test_filteringstrategy.cpp

Loading...

kdevplatform/project/abstractfilemanagerplugin.cpp

Loading...

kdevplatform/serialization/itemrepositoryregistry.h

Loading...

kdevplatform/serialization/itemrepositoryregistry.cpp

Loading...

kdevplatform/shell/documentcontroller.cpp

Loading...

kdevplatform/shell/mainwindow_actions.cpp

Loading...

kdevplatform/shell/openprojectdialog.cpp

Loading...

kdevplatform/shell/openprojectpage.h

Loading...

kdevplatform/shell/openprojectpage.cpp

Loading...

kdevplatform/shell/progresswidget/progressmanager.h

Loading...

kdevplatform/shell/statusbar.cpp

Loading...

kdevplatform/shell/tests/test_shellbuddy.cpp

Loading...

kdevplatform/sublime/mainwindow.h

Loading...

kdevplatform/sublime/mainwindow.cpp

Loading...

kdevplatform/util/texteditorhelpers.cpp

Loading...

kdevplatform/vcs/dvcs/dvcsplugin.h

Loading...

kdevplatform/vcs/vcsrevision.h

Loading...

kdevplatform/vcs/vcsrevision.cpp

Loading...

plugins/appwizard/projectselectionpage.h

Loading...

plugins/appwizard/projectselectionpage.cpp

Loading...

plugins/clang/clangsupport.h

Loading...

plugins/clang/clangsupport.cpp

Loading...

plugins/clang/codecompletion/completionhelper.cpp

Loading...

plugins/clang/duchain/clangindex.cpp

Loading...

plugins/clang/duchain/documentfinderhelpers.h

Loading...

plugins/clang/duchain/documentfinderhelpers.cpp

Loading...

plugins/clang/tests/test_buddies.cpp

Loading...

plugins/contextbrowser/contextbrowser.cpp

Loading...

plugins/custommake/makefileresolver/makefileresolver.cpp

Loading...

plugins/git/gitplugin.h

Loading...

plugins/git/gitplugin.cpp

Loading...

plugins/git/tests/test_git.cpp

Loading...

plugins/switchtobuddy/switchtobuddyplugin.cpp

Loading...