Differential D1448

Add a virtual_desktop_changable state to the window protocol.
ClosedPublic
Actions

Authored by hein on Apr 19 2016, 4:16 PM.

Details

Reviewers

graesslin

Commits

R127:021f67f3f470: Add a virtual_desktop_changable state to the window protocol.

Summary

Analogous to NET::ActionChangeDesktop.

KWindowInfo::actionSupported(NET::ActionChangeDesktop) is hardcoded
to return true in kwin, but that's not how it should be; as this will
be fixed later the Wayland protocol needs this state bit as well for
parity.

Test Plan

PlasmaWindowModel test is extended.

Diff Detail

Repository

R127 KWayland

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

hein updated this revision to Diff 3427.Apr 19 2016, 4:16 PM

hein retitled this revision from to Add a virtual_desktop_changable state to the window protocol..

hein updated this object.

hein edited the test plan for this revision. (Show Details)

hein added a reviewer: graesslin.

hein added a subscriber: plasma-devel.

Restricted Application added a project: Plasma. · View Herald TranscriptApr 19 2016, 4:16 PM

hein added a dependent revision: D1449: Hook up virtual_desktop_changeable state..Apr 19 2016, 4:35 PM

graesslin accepted this revision.Apr 20 2016, 6:18 AM

graesslin edited edge metadata.

This revision is now accepted and ready to land.Apr 20 2016, 6:18 AM

Closed by commit R127:021f67f3f470: Add a virtual_desktop_changable state to the window protocol. (authored by hein). · Explain WhyApr 20 2016, 7:17 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/client/test_plasma_window_model.cpp (8 lines)
M			src/client/plasmawindowmanagement.h (8 lines)
M			src/client/plasmawindowmanagement.cpp (17 lines)
M			src/client/plasmawindowmodel.h (6 lines)
M			src/client/plasmawindowmodel.cpp (6 lines)
M			src/client/protocols/plasma-window-management.xml (1 line)
M			src/server/plasmawindowmanagement_interface.h (8 lines)
M			src/server/plasmawindowmanagement_interface.cpp (8 lines)