Differential D1440

Move ShellClient initialization code into a dedicated init method
ClosedPublic
Actions

Authored by graesslin on Apr 18 2016, 11:32 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R108:013de158b720: Move ShellClient initialization code into a dedicated init method
Summary

Preparation for also supporting XdgShell. There will be different
ctors for ShellSurface and XdgShell, but most code needs to be shared.
Thus a dedicated init method is needed.

There is some restructuring in the init. All code depending on
ShellSurface being set is grouped and in an if block.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 3399.Apr 18 2016, 11:32 AM
graesslin retitled this revision from to Move ShellClient initialization code into a dedicated init method.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptApr 18 2016, 11:32 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Apr 19 2016, 7:53 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Apr 19 2016, 7:53 AM
Closed by commit R108:013de158b720: Move ShellClient initialization code into a dedicated init method (authored by graesslin). · Explain WhyApr 19 2016, 11:32 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mshell_client.h (1 line)
Mshell_client.cpp (147 lines)

Diff 3414

View Options

shell_client.h

Loading...
View Options

shell_client.cpp

Loading...