Remove unused WITH_KF5 cmake var
AbandonedPublic

Authored by kossebau on Apr 18 2016, 11:15 AM.

Details

Reviewers
nienhueser
Summary

Seems that was only temporarily used, correct?
Could not find any place where this is checked.

Diff Detail

Repository
R34 Marble
Branch
removeUnusedWITH_KF5
Lint
No Linters Available
Unit
No Unit Test Coverage
kossebau updated this revision to Diff 3398.Apr 18 2016, 11:15 AM
kossebau retitled this revision from to Remove unused WITH_KF5 cmake var.
kossebau updated this object.
kossebau edited the test plan for this revision. (Show Details)
kossebau added a reviewer: nienhueser.
nienhueser edited edge metadata.Apr 18 2016, 8:01 PM

Iirc with_kf5 comes implicitly through the optional dependency macro we use.

Iirc with_kf5 comes implicitly through the optional dependency macro we use.

What "optional dependency macro", I did not get across that one?
hm, lxr.kde.org only shows this very line in Marble. And google in its search result on "with_kf5" Marble developers/packagers talking about it, and then something in Quassel which seems self-used var though. No
Any suggestions who could know more? I have never seen it in all my porting work so far :) (perhaps that was Qt4/Qt5-parallel build specific?).

kossebau edited edge metadata.Apr 19 2016, 12:40 AM
kossebau added a project: Marble.

I mean MACRO_OPTIONAL_FIND_PACKAGE from MarbleMacros.cmake. It has

option(WITH_${_name} "Search for ${_name} package" ON)
if (WITH_${_name})
   find_package(${_name} ${ARGN})
else (WITH_${_name})

and we call it like

macro_optional_find_package(KF5 ...

kossebau abandoned this revision.Apr 27 2016, 6:38 PM

I see. Okay, discarding this one.