Differential D14299

kirigami_package_breeze_icons: don't treat lists as elements
ClosedPublic
Actions

Authored by apol on Jul 23 2018, 2:13 PM.

Details

Reviewers
mart
vkrause
andreaska
Commits
R169:a492ecde6467: kirigami_package_breeze_icons: don't treat lists as elements
Summary

GLOB_RECURSE will give us a list, treat it as such.
Also when the list has more than just one item, pick the first as the best
candidate.
Some cases like help-about has more than one and it fails currently.

CCBUG: 396626

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Jul 23 2018, 2:13 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptJul 23 2018, 2:13 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Jul 23 2018, 2:13 PM
apol updated this revision to Diff 38257.Jul 23 2018, 2:13 PM

Include a warning

mart accepted this revision.Jul 23 2018, 2:17 PM
This revision is now accepted and ready to land.Jul 23 2018, 2:17 PM
Closed by commit R169:a492ecde6467: kirigami_package_breeze_icons: don't treat lists as elements (authored by apol). · Explain WhyJul 23 2018, 2:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MKF5Kirigami2Macros.cmake (13 lines)

Diff 38260

View Options

KF5Kirigami2Macros.cmake

Loading...