Differential D14296

Fix option "Expand individual tab to full window"
ClosedPublic
Actions

Authored by tcanabrava on Jul 23 2018, 12:06 PM.

Details

Reviewers
sandsmark
hindenburg
Group Reviewers
Konsole
Commits
R319:50cbc1d9301d: Fix option "Expand individual tab to full window"
R319:90ec94f7b6d5: Revert "break build to test failure email to ml"

Diff Detail

Repository
R319 Konsole
Branch
fixTabExpandable
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1129
Build 1142: arc lint + arc unit
tcanabrava created this revision.Jul 23 2018, 12:06 PM
Restricted Application added a project: Konsole. · View Herald TranscriptJul 23 2018, 12:06 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
tcanabrava requested review of this revision.Jul 23 2018, 12:06 PM
hindenburg added a comment.Jul 24 2018, 1:35 AM

Calling qdbus $KONSOLE_DBUS_SERVICE $KONSOLE_DBUS_WINDOW setTabWidthToText true and false causes visual glitches *tabs overlap" for a few seconds until it corrects itself. And sometimes false doesn't work. Tested w/ close button enabled.

tcanabrava updated this revision to Diff 38326.Jul 24 2018, 11:16 AM
  • Fix repaint after calling dbus method to change tab size
tcanabrava added a comment.Jul 24 2018, 11:37 AM

Important to note that this code actually fixes a bug in the old implementation where two tabbar areas and a dbus call to expand would expand only the current active tabbar.

hindenburg accepted this revision.Jul 24 2018, 1:43 PM

Thanks, I meant to test how it worked before the changes but didn't get around to it.

This revision is now accepted and ready to land.Jul 24 2018, 1:43 PM
hindenburg retitled this revision from Fix "expand tabs to full window" to Fix option "Expand individual tab to full window".Jul 24 2018, 1:45 PM
Closed by commit R319:50cbc1d9301d: Fix option "Expand individual tab to full window" (authored by tcanabrava, committed by hindenburg). · Explain WhyJul 24 2018, 1:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/ViewContainer.cpp (2 lines)
Msrc/ViewManager.h (3 lines)
Msrc/ViewManager.cpp (8 lines)

Diff 38326

View Options

src/ViewContainer.cpp

Loading...
View Options

src/ViewManager.h

Loading...
View Options

src/ViewManager.cpp

Loading...