Differential D14295

Re-enable profile menu for new tab button and restore close button behavior
ClosedPublic
Actions

Authored by tcanabrava on Jul 23 2018, 11:33 AM.

Details

Reviewers
sandsmark
hindenburg
Group Reviewers
Konsole
Commits
R319:953c250fe9db: Re-enable profile menu for new tab button and restore close button behavior
Summary

This patch fixes the lack of profile in the new tab button,
and it makes the close button to behave the same way
as the old implementation.

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tcanabrava created this revision.Jul 23 2018, 11:33 AM
Restricted Application added a project: Konsole. · View Herald TranscriptJul 23 2018, 11:33 AM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
tcanabrava requested review of this revision.Jul 23 2018, 11:33 AM
tcanabrava edited the summary of this revision. (Show Details)Jul 23 2018, 11:34 AM
tcanabrava added reviewers: Konsole, sandsmark, hindenburg.
hindenburg accepted this revision.Jul 24 2018, 2:45 AM
This revision is now accepted and ready to land.Jul 24 2018, 2:45 AM
hindenburg requested changes to this revision.Jul 24 2018, 2:47 AM
hindenburg retitled this revision from Profile Menu for New Tab Button and fix close button behavior to Re-enable profile menu for new tab button and restore close button behavior.
hindenburg edited the summary of this revision. (Show Details)
This revision now requires changes to proceed.Jul 24 2018, 2:48 AM
hindenburg accepted this revision.Jul 24 2018, 2:48 AM
This revision is now accepted and ready to land.Jul 24 2018, 2:48 AM
Closed by commit R319:953c250fe9db: Re-enable profile menu for new tab button and restore close button behavior (authored by tcanabrava, committed by hindenburg). · Explain WhyJul 24 2018, 2:49 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/ViewContainer.h (1 line)
Msrc/ViewContainer.cpp (15 lines)

Diff 38283

View Options

src/ViewContainer.h

Loading...
View Options

src/ViewContainer.cpp

Loading...