Differential D14277

qmljs: Make string code more robust by checking isEmpty over isNull
ClosedPublic
Actions

Authored by kossebau on Jul 22 2018, 3:10 PM.

Details

Reviewers
apol
Group Reviewers
KDevelop
Commits
R32:82d6729d48cf: qmljs: Make string code more robust by checking isEmpty over isNull
Summary

In all cases empty non-null QStrings match the tested cases as well, so the
code better catches those QString variants as well, not just empty null
ones.
Makes the code looking less fragile (no special handling of null QStrings)

Test Plan

Tests work/fail as before ;)

Diff Detail

Repository
R32 KDevelop
Branch
changesomeisnull
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1066
Build 1079: arc lint + arc unit
kossebau created this revision.Jul 22 2018, 3:10 PM
Restricted Application added a project: KDevelop. · View Herald TranscriptJul 22 2018, 3:10 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
kossebau requested review of this revision.Jul 22 2018, 3:10 PM
apol accepted this revision.Jul 22 2018, 10:45 PM
This revision is now accepted and ready to land.Jul 22 2018, 10:45 PM
Closed by commit R32:82d6729d48cf: qmljs: Make string code more robust by checking isEmpty over isNull (authored by kossebau). · Explain WhyJul 23 2018, 8:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 38207

View Options

plugins/qmljs/duchain/cache.cpp

Loading...
View Options

plugins/qmljs/duchain/declarationbuilder.cpp

Loading...
View Options

plugins/qmljs/duchain/frameworks/nodejs.cpp

Loading...
View Options

plugins/qmljs/duchain/helper.cpp

Loading...