qmljs: Make string code more robust by checking isEmpty over isNull
ClosedPublic

Authored by kossebau on Jul 22 2018, 3:10 PM.

Details

Summary

In all cases empty non-null QStrings match the tested cases as well, so the
code better catches those QString variants as well, not just empty null
ones.
Makes the code looking less fragile (no special handling of null QStrings)

Test Plan

Tests work/fail as before ;)

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Jul 22 2018, 3:10 PM
Restricted Application added a project: KDevelop. · View Herald TranscriptJul 22 2018, 3:10 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
kossebau requested review of this revision.Jul 22 2018, 3:10 PM
apol accepted this revision.Jul 22 2018, 10:45 PM
This revision is now accepted and ready to land.Jul 22 2018, 10:45 PM
This revision was automatically updated to reflect the committed changes.