Does this need to be applied on top of the other patch, or can it be applied directly?

In D14249#295321, @rempt wrote:

Does this need to be applied on top of the other patch, or can it be applied directly?

It needs to be applied on top of branch amedonosova/gamut-masking (https://commits.kde.org/krita/dbe05327705fde0b0d6b56451322e4deddc6fc24).

This is looking good! I feel it's getting close to be ready to merge to master.

In D14249#297455, @rempt wrote:

This is looking good! I feel it's getting close to be ready to merge to master.

Thanks.

I have found two things while painting today:

• First is a bug: select a color on the wheel -> pick a color from canvas -> select other value on scale => the selector reverts to previously selected color. It should be trivial to fix.
• Second, I think artists would benefit from having the option to set gamma for the value scale. That should also be easy to add.

I also have a basic prototype of masking for the advanced color selector (in a separate branch), which I created to see whether the implementation really can handle multiple selectors simultaneously. I have found no problems so far. I'm not adding that to this differential, as I would prefer to work on the advanced selector later after my currently submitted work is more stable/thoroughly tested.

I have fixed the issues with color selection.

I have also added the option to set gamma correction for the value scale (in HSY mode). I'm not entirely sure that the implementation is mathematically correct, although it seems to get it's job done well.

Is there anything else to be done?

I don't think there's much more left to do! I'm quite impressed. I do want Dmitry to take a look as well, since he's more thorough when it comes to code review than me.

Dmitry is visiting relatives this week, though, so he might not have time immediately.

I'm wondering -- what's the current status? Should we merge this work to master so people start playing with it?

Good evening,

I have not found any major bugs since my last update, I focused on content for user documentation, which is now complete.

If there are no other problems to fix, I will rebase my code on top of master; the gamut-masking branch is now fairly behind.

As for the merging itself, is there some process or best practice I should follow (including submitting documentation, notifying artists,...)?

Good afternoon,

1. BUG: Closing the gamut document (with saving) doesn't save the changes to the mask itself
   1. Proposed solution: I guess we should just ask the user if he wants to save the closed document into the mask or not.

I have implemented it as you proposed. In addition, the docker is tracking saving of the template document. If the user saves the document and makes no further changes, the docker does not ask again and saves the mask. This avoids a situation with two identical subsequent save dialogs, when you modify the template and then close the view without saving first.

2. BUG: Entering gamut mask editing mode twice discards the changes in the first mask.
   1. Proposed solutions:
      1. Solution1: just disable edit/create mask buttons when the user already edits something.
      2. Solution2: when entering edit mode for the second time, close the previously opened document (asking the user if he would like to save or not)

Here I have done two things.
1, When a template document is opened, the mask management toolbar is hidden (as proposed in solution 1).
2, When you have a template open and select another mask, the user is asked whether he wants the mask to be saved (if it was previously saved or modified) and then the template is closed and the new mask is selected.

3. WISH: It would be really nice to be able to rotate the gamut mask around the center point. Then the user can use the predefined masks (like Complementary or Atmospheric_Triag) without any changes. Just rotate them to cover the needed colors and start painting :)

That would be really nice to have, thank you for the feature, I have added it to my list of enhancements. If you don't mind, I would prefer to do it separately in a later revision.

While fixing the above bugs, I have seen a crash in saving the template document which might indicate that I am doing something wrong in my code. It happened three times, not in sequence, possibly due to some race condition. I have since then made some changes to the code and now I am unable to reproduce it. Steps to reproduce:
1, select a mask, click edit
2, modify the template, do not save
3, close the view
4, in the save/cancel dialog choose 'save'
5, krita crashes

I am attaching a backtrace from this crash:

Could you please help me confirm the crash is gone, and if not, find why it happens and how to fix that?