Differential D14208

Duplicated notes in KNotes
ClosedPublic
Actions

Authored by McPain on Jul 18 2018, 2:43 PM.

Details

Reviewers
mlaurent
Commits
R208:7f92d12de349: Apply patch from Oleg Solovyov
Summary

BUG: 334138

Test Plan
  1. Hide collection
  2. Create a note and put it to hidden collection
  3. Your note will appear once (twice w/o fix)

Diff Detail

Repository
R208 KNotes
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
McPain created this revision.Jul 18 2018, 2:43 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptJul 18 2018, 2:43 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
McPain requested review of this revision.Jul 18 2018, 2:43 PM
mlaurent accepted this revision.Jul 18 2018, 4:30 PM

Seems ok.
Thanks
I think that we need to exclude fetch from hidden collections.

This revision is now accepted and ready to land.Jul 18 2018, 4:30 PM
mlaurent added a comment.Jul 19 2018, 5:52 AM

Do you have commit access ?

McPain added a comment.Jul 19 2018, 6:50 AM
In D14208#294601, @mlaurent wrote:

Do you have commit access ?

No. Can I get it?

mlaurent added a comment.Jul 19 2018, 7:19 AM

I will commit for you after lunch.

You can ask commit access after several patchs
Regards

Closed by commit R208:7f92d12de349: Apply patch from Oleg Solovyov (authored by mlaurent). · Explain WhyJul 19 2018, 11:36 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/apps/knotesapp.cpp (2 lines)

Diff 38087

View Options

src/apps/knotesapp.cpp

Loading...