Differential D1414

ClosedPublic
Actions

Authored by graesslin on Apr 15 2016, 8:36 AM.

Details

Reviewers

sebas

Group Reviewers

Plasma

Commits

R108:e4c333a372ae: Move clients/ to plugins/kdecorations/

Summary

KWin's plugins are now all in a plugins subdirectory. This is a good
argument to also move the window decoration plugins there. The name
clients was not really good anyway and makes it difficult for people
not familiar with the code base to find it. Having it under plugins
is the more expectable location.

Diff Detail

Repository

R108 KWin

Branch

clients-to-plugins

Lint

No Linters Available

Unit

No Unit Test Coverage

graesslin updated this revision to Diff 3350.Apr 15 2016, 8:36 AM

graesslin retitled this revision from to Move clients/ to plugins/kdecorations/.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added a reviewer: Plasma.

Restricted Application added a project: Plasma. · View Herald TranscriptApr 15 2016, 8:36 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

sebas accepted this revision.Apr 15 2016, 1:13 PM

sebas added a reviewer: sebas.

sebas added a subscriber: sebas.

sebas added inline comments.

plugins/CMakeLists.txt
6	spaces-- (also next line)

This revision is now accepted and ready to land.Apr 15 2016, 1:13 PM

graesslin marked an inline comment as done.Apr 15 2016, 1:21 PM

Closed by commit R108:e4c333a372ae: Move clients/ to plugins/kdecorations/ (authored by graesslin). · Explain WhyApr 15 2016, 1:23 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (3 lines)
V			{clients → plugins/kdecorations}/CMakeLists.txt (2 lines)
V			{clients → plugins/kdecorations}/Messages.sh (4 lines)
V			{clients → plugins/kdecorations}/aurorae/AUTHORS (1 line)
V			{clients → plugins/kdecorations}/aurorae/CMakeLists.txt (4 lines)
V			{clients → plugins/kdecorations}/aurorae/README (6 lines)
V			{clients → plugins/kdecorations}/aurorae/TODO (3 lines)
V			{clients → plugins/kdecorations}/aurorae/src/CMakeLists.txt (64 lines)
V			{clients → plugins/kdecorations}/aurorae/src/aurorae.h (135 lines)
V			{clients → plugins/kdecorations}/aurorae/src/aurorae.cpp (772 lines)
V			{clients → plugins/kdecorations}/aurorae/src/aurorae.json (22 lines)
V			{clients → plugins/kdecorations}/aurorae/src/aurorae.knsrc (5 lines)
V			{clients → plugins/kdecorations}/aurorae/src/colorhelper.h (240 lines)
V			{clients → plugins/kdecorations}/aurorae/src/colorhelper.cpp (63 lines)
V			{clients → plugins/kdecorations}/aurorae/src/decorationoptions.h (318 lines)
V			{clients → plugins/kdecorations}/aurorae/src/decorationoptions.cpp (269 lines)
V			{clients → plugins/kdecorations}/aurorae/src/decorationplugin.h (29 lines)
V			{clients → plugins/kdecorations}/aurorae/src/decorationplugin.cpp (29 lines)
V			{clients → plugins/kdecorations}/aurorae/src/kwindecoration.desktop (61 lines)
V			{clients → plugins/kdecorations}/aurorae/src/lib/auroraetheme.h (229 lines)
V			{clients → plugins/kdecorations}/aurorae/src/lib/auroraetheme.cpp (505 lines)
V			{clients → plugins/kdecorations}/aurorae/src/lib/themeconfig.h (413 lines)
V			{clients → plugins/kdecorations}/aurorae/src/lib/themeconfig.cpp (190 lines)
V			{clients → plugins/kdecorations}/aurorae/src/qml/AppMenuButton.qml (29 lines)
V			{clients → plugins/kdecorations}/aurorae/src/qml/AuroraeButton.qml (215 lines)
V			{clients → plugins/kdecorations}/aurorae/src/qml/AuroraeButtonGroup.qml (60 lines)
V			{clients → plugins/kdecorations}/aurorae/src/qml/AuroraeMaximizeButton.qml (69 lines)
V			{clients → plugins/kdecorations}/aurorae/src/qml/ButtonGroup.qml (101 lines)
V			{clients → plugins/kdecorations}/aurorae/src/qml/Decoration.qml (36 lines)
V			{clients → plugins/kdecorations}/aurorae/src/qml/DecorationButton.qml (124 lines)
V			{clients → plugins/kdecorations}/aurorae/src/qml/MenuButton.qml (81 lines)
V			{clients → plugins/kdecorations}/aurorae/src/qml/aurorae.qml (220 lines)
V			{clients → plugins/kdecorations}/aurorae/src/qml/qmldir (8 lines)
V			{clients → plugins/kdecorations}/aurorae/theme-description (163 lines)
V			{clients → plugins/kdecorations}/aurorae/themes/CMakeLists.txt (1 line)
V			{clients → plugins/kdecorations}/aurorae/themes/plastik/CMakeLists.txt (8 lines)
V			{clients → plugins/kdecorations}/aurorae/themes/plastik/code/CMakeLists.txt (9 lines)
V			{clients → plugins/kdecorations}/aurorae/themes/plastik/code/plastikbutton.h (84 lines)
V			{clients → plugins/kdecorations}/aurorae/themes/plastik/code/plastikbutton.cpp (467 lines)
V			{clients → plugins/kdecorations}/aurorae/themes/plastik/code/plastikplugin.h (31 lines)
V			{clients → plugins/kdecorations}/aurorae/themes/plastik/code/plastikplugin.cpp (33 lines)
V			{clients → plugins/kdecorations}/aurorae/themes/plastik/code/qmldir (5 lines)
V			{clients → plugins/kdecorations}/aurorae/themes/plastik/package/contents/config/main.xml (28 lines)
V			{clients → plugins/kdecorations}/aurorae/themes/plastik/package/contents/ui/PlastikButton.qml (161 lines)
V			{clients → plugins/kdecorations}/aurorae/themes/plastik/package/contents/ui/config.ui (99 lines)
V			{clients → plugins/kdecorations}/aurorae/themes/plastik/package/contents/ui/main.qml (428 lines)
V			{clients → plugins/kdecorations}/aurorae/themes/plastik/package/metadata.desktop (152 lines)
M			plugins/CMakeLists.txt (4 lines)
V			{plugins/kdecorations ← clients}/CMakeLists.txt (2 lines)
V			{plugins/kdecorations ← clients}/Messages.sh (4 lines)
V			{plugins/kdecorations ← clients}/aurorae/AUTHORS (1 line)
V			{plugins/kdecorations ← clients}/aurorae/CMakeLists.txt (4 lines)
V			{plugins/kdecorations ← clients}/aurorae/README (6 lines)
V			{plugins/kdecorations ← clients}/aurorae/TODO (3 lines)
V			{plugins/kdecorations ← clients}/aurorae/src/CMakeLists.txt (64 lines)
V			{plugins/kdecorations ← clients}/aurorae/src/aurorae.h (135 lines)
V			{plugins/kdecorations ← clients}/aurorae/src/aurorae.cpp (772 lines)
V			{plugins/kdecorations ← clients}/aurorae/src/aurorae.json (22 lines)
V			{plugins/kdecorations ← clients}/aurorae/src/aurorae.knsrc (5 lines)
V			{plugins/kdecorations ← clients}/aurorae/src/colorhelper.h (240 lines)
V			{plugins/kdecorations ← clients}/aurorae/src/colorhelper.cpp (63 lines)
V			{plugins/kdecorations ← clients}/aurorae/src/decorationoptions.h (318 lines)
V			{plugins/kdecorations ← clients}/aurorae/src/decorationoptions.cpp (269 lines)
V			{plugins/kdecorations ← clients}/aurorae/src/decorationplugin.h (29 lines)
V			{plugins/kdecorations ← clients}/aurorae/src/decorationplugin.cpp (29 lines)
V			{plugins/kdecorations ← clients}/aurorae/src/kwindecoration.desktop (61 lines)
V			{plugins/kdecorations ← clients}/aurorae/src/lib/auroraetheme.h (229 lines)
V			{plugins/kdecorations ← clients}/aurorae/src/lib/auroraetheme.cpp (505 lines)
V			{plugins/kdecorations ← clients}/aurorae/src/lib/themeconfig.h (413 lines)
V			{plugins/kdecorations ← clients}/aurorae/src/lib/themeconfig.cpp (190 lines)
V			{plugins/kdecorations ← clients}/aurorae/src/qml/AppMenuButton.qml (29 lines)
V			{plugins/kdecorations ← clients}/aurorae/src/qml/AuroraeButton.qml (215 lines)
V			{plugins/kdecorations ← clients}/aurorae/src/qml/AuroraeButtonGroup.qml (60 lines)
V			{plugins/kdecorations ← clients}/aurorae/src/qml/AuroraeMaximizeButton.qml (69 lines)
V			{plugins/kdecorations ← clients}/aurorae/src/qml/ButtonGroup.qml (101 lines)
V			{plugins/kdecorations ← clients}/aurorae/src/qml/Decoration.qml (36 lines)
V			{plugins/kdecorations ← clients}/aurorae/src/qml/DecorationButton.qml (124 lines)
V			{plugins/kdecorations ← clients}/aurorae/src/qml/MenuButton.qml (81 lines)
V			{plugins/kdecorations ← clients}/aurorae/src/qml/aurorae.qml (220 lines)
V			{plugins/kdecorations ← clients}/aurorae/src/qml/qmldir (8 lines)
V			{plugins/kdecorations ← clients}/aurorae/theme-description (163 lines)
V			{plugins/kdecorations ← clients}/aurorae/themes/CMakeLists.txt (1 line)
V			{plugins/kdecorations ← clients}/aurorae/themes/plastik/CMakeLists.txt (8 lines)
V			{plugins/kdecorations ← clients}/aurorae/themes/plastik/code/CMakeLists.txt (9 lines)
V			{plugins/kdecorations ← clients}/aurorae/themes/plastik/code/plastikbutton.h (84 lines)
V			{plugins/kdecorations ← clients}/aurorae/themes/plastik/code/plastikbutton.cpp (467 lines)
V			{plugins/kdecorations ← clients}/aurorae/themes/plastik/code/plastikplugin.h (31 lines)
V			{plugins/kdecorations ← clients}/aurorae/themes/plastik/code/plastikplugin.cpp (33 lines)
V			{plugins/kdecorations ← clients}/aurorae/themes/plastik/code/qmldir (5 lines)
V			{plugins/kdecorations ← clients}/aurorae/themes/plastik/package/contents/config/main.xml (28 lines)
V			{plugins/kdecorations ← clients}/aurorae/themes/plastik/package/contents/ui/PlastikButton.qml (161 lines)
V			{plugins/kdecorations ← clients}/aurorae/themes/plastik/package/contents/ui/config.ui (99 lines)
V			{plugins/kdecorations ← clients}/aurorae/themes/plastik/package/contents/ui/main.qml (428 lines)
V			{plugins/kdecorations ← clients}/aurorae/themes/plastik/package/metadata.desktop (152 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	3350	2489912		Apr 15 2016, 8:36 AM	★	★
Diff 2	3359	702b84b	rKWINe4c333a372ae4f64ec367fc153bcaec89293f5ea	Apr 15 2016, 1:21 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
7af7d66db422	9dd9e3587e70	248991223b19	Martin Gräßlin	Move clients/ to plugins/kdecorations/ (Show More…)	Apr 15 2016, 8:34 AM

Move clients/ to plugins/kdecorations/ClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 3350

CMakeLists.txt

clients/CMakeLists.txt

clients/Messages.sh

clients/aurorae/AUTHORS

clients/aurorae/CMakeLists.txt

clients/aurorae/README

clients/aurorae/TODO

clients/aurorae/src/CMakeLists.txt

clients/aurorae/src/aurorae.h

clients/aurorae/src/aurorae.cpp

clients/aurorae/src/aurorae.json

clients/aurorae/src/aurorae.knsrc

clients/aurorae/src/colorhelper.h

clients/aurorae/src/colorhelper.cpp

clients/aurorae/src/decorationoptions.h

clients/aurorae/src/decorationoptions.cpp

clients/aurorae/src/decorationplugin.h

clients/aurorae/src/decorationplugin.cpp

clients/aurorae/src/kwindecoration.desktop

clients/aurorae/src/lib/auroraetheme.h

clients/aurorae/src/lib/auroraetheme.cpp

clients/aurorae/src/lib/themeconfig.h

clients/aurorae/src/lib/themeconfig.cpp

clients/aurorae/src/qml/AppMenuButton.qml

clients/aurorae/src/qml/AuroraeButton.qml

clients/aurorae/src/qml/AuroraeButtonGroup.qml

clients/aurorae/src/qml/AuroraeMaximizeButton.qml

clients/aurorae/src/qml/ButtonGroup.qml

clients/aurorae/src/qml/Decoration.qml

clients/aurorae/src/qml/DecorationButton.qml

clients/aurorae/src/qml/MenuButton.qml

clients/aurorae/src/qml/aurorae.qml

clients/aurorae/src/qml/qmldir

clients/aurorae/theme-description

clients/aurorae/themes/CMakeLists.txt

clients/aurorae/themes/plastik/CMakeLists.txt

clients/aurorae/themes/plastik/code/CMakeLists.txt

clients/aurorae/themes/plastik/code/plastikbutton.h

clients/aurorae/themes/plastik/code/plastikbutton.cpp

clients/aurorae/themes/plastik/code/plastikplugin.h

clients/aurorae/themes/plastik/code/plastikplugin.cpp

clients/aurorae/themes/plastik/code/qmldir

clients/aurorae/themes/plastik/package/contents/config/main.xml

clients/aurorae/themes/plastik/package/contents/ui/PlastikButton.qml

clients/aurorae/themes/plastik/package/contents/ui/config.ui

clients/aurorae/themes/plastik/package/contents/ui/main.qml

clients/aurorae/themes/plastik/package/metadata.desktop

plugins/CMakeLists.txt

plugins/kdecorations/CMakeLists.txt

plugins/kdecorations/Messages.sh

plugins/kdecorations/aurorae/AUTHORS

plugins/kdecorations/aurorae/CMakeLists.txt

plugins/kdecorations/aurorae/README

plugins/kdecorations/aurorae/TODO

plugins/kdecorations/aurorae/src/CMakeLists.txt

plugins/kdecorations/aurorae/src/aurorae.h

plugins/kdecorations/aurorae/src/aurorae.cpp

plugins/kdecorations/aurorae/src/aurorae.json

plugins/kdecorations/aurorae/src/aurorae.knsrc

plugins/kdecorations/aurorae/src/colorhelper.h

plugins/kdecorations/aurorae/src/colorhelper.cpp

plugins/kdecorations/aurorae/src/decorationoptions.h

plugins/kdecorations/aurorae/src/decorationoptions.cpp

plugins/kdecorations/aurorae/src/decorationplugin.h

plugins/kdecorations/aurorae/src/decorationplugin.cpp

plugins/kdecorations/aurorae/src/kwindecoration.desktop

plugins/kdecorations/aurorae/src/lib/auroraetheme.h

plugins/kdecorations/aurorae/src/lib/auroraetheme.cpp

plugins/kdecorations/aurorae/src/lib/themeconfig.h

plugins/kdecorations/aurorae/src/lib/themeconfig.cpp

plugins/kdecorations/aurorae/src/qml/AppMenuButton.qml

plugins/kdecorations/aurorae/src/qml/AuroraeButton.qml

plugins/kdecorations/aurorae/src/qml/AuroraeButtonGroup.qml

plugins/kdecorations/aurorae/src/qml/AuroraeMaximizeButton.qml

plugins/kdecorations/aurorae/src/qml/ButtonGroup.qml

Move clients/ to plugins/kdecorations/
ClosedPublic
Actions

Revision Contents
Changeset List