Differential D14124

Fix qtplugins in KStandardDirs
ClosedPublic
Actions

Authored by arojas on Jul 15 2018, 8:02 AM.

Details

Reviewers
dfaure
Commits
R239:3ab2e2f5592d: Fix qtplugins in KStandardDirs
Summary

PLUGIN_INSTALL_DIR already contains the /plugins/ suffix, don't duplicate it

Test Plan

'kf5-config --path qtplugins' returns the right thing

Diff Detail

Repository
R239 KDELibs4Support
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
arojas created this revision.Jul 15 2018, 8:02 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 15 2018, 8:02 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
arojas requested review of this revision.Jul 15 2018, 8:02 AM
dfaure accepted this revision.Jul 15 2018, 9:37 AM

Interestingly it works for me with and without this patch, because of "%lib/plugins/" later on in the code, but indeed at that point installdir is /d/kde/inst/kde_frameworks/lib64/plugins/plugins/ which looks wrong.

This revision is now accepted and ready to land.Jul 15 2018, 9:37 AM
Closed by commit R239:3ab2e2f5592d: Fix qtplugins in KStandardDirs (authored by arojas). · Explain WhyJul 15 2018, 10:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kdecore/kstandarddirs.cpp (2 lines)

Diff 37794

View Options

src/kdecore/kstandarddirs.cpp

Loading...