kmymoney/plugins/views/reports/core/tests/pivottable-test.cpp
53	filename = QString("report-%1.csv").arg((filenumber, 2, 10,QLatin1Char('0')); I know, you just used the old code, but we should improve it while we're at it.
69	filename = QString("report-%1.csv").arg((filenumber, 2, 10,QLatin1Char('0'));
kmymoney/plugins/views/reports/core/tests/querytable-test.cpp
50	filename = QString("report-%1.csv").arg((filenumber, 2, 10,QLatin1Char('0'));
65	filename = QString("qreport-%1.csv").arg((filenumber, 2, 10,QLatin1Char('0')); Not sure, if the leading q in the filename is just a typo or really wanted since all others don't have it.

This revision now requires changes to proceed.Jul 15 2018, 7:04 AM

This revision was not accepted when it landed; it landed in state Needs Revision.Jul 15 2018, 9:19 AM

This revision was automatically updated to reflect the committed changes.

I think it's not a good idea to improve code on such occasions. Code could be easily broken and it would be hard to find a cause.

Revision Contents
Changeset List

			Path	Packages
M			kmymoney/converter/CMakeLists.txt (19 lines)
M			kmymoney/converter/tests/CMakeLists.txt (2 lines)
M			kmymoney/converter/tests/converter-test.cpp (2 lines)
M			kmymoney/mymoney/tests/CMakeLists.txt (2 lines)
M			kmymoney/mymoney/tests/mymoneyforecast-test.cpp (2 lines)
M			kmymoney/plugins/CMakeLists.txt (2 lines)
M			kmymoney/plugins/views/CMakeLists.txt (2 lines)
M			kmymoney/plugins/views/reports/core/tests/CMakeLists.txt (12 lines)
M			kmymoney/plugins/views/reports/core/tests/pivotgrid-test.cpp (2 lines)
M			kmymoney/plugins/views/reports/core/tests/pivottable-test.cpp (33 lines)
M			kmymoney/plugins/views/reports/core/tests/querytable-test.cpp (32 lines)
V			kmymoney/{plugins/views/reports/core/tests/reportstestcommon.h → tests/testutilities.h}
V			kmymoney/{plugins/views/reports/core/tests/reportstestcommon.cpp → tests/testutilities.cpp}
M			kmymoney/plugins/xml/mymoneystoragexml.cpp (5 lines)
M			kmymoney/tests/CMakeLists.txt (10 lines)
V			kmymoney/{tests/testutilities.h ← plugins/views/reports/core/tests/reportstestcommon.h} (4 lines)
V			kmymoney/{tests/testutilities.cpp ← plugins/views/reports/core/tests/reportstestcommon.cpp} (79 lines)