Differential D14053

avoid runtime error about unknown signal when compiled without WebKit
ClosedPublic
Actions

Authored by mkoller on Jul 11 2018, 5:16 PM.

Details

Reviewers
rahn
Group Reviewers
Marble
Commits
R34:c4850695c31d: avoid runtime error about unknown signal when compiled without WebKit
Summary

When compiled without WebKit, (MARBLE_NO_WEBKITWIDGETS defined), I get runtime errors about unknown signals.
This patch solves this.

Diff Detail

Repository
R34 Marble
Lint
Lint Skipped
Unit
Unit Tests Skipped
mkoller created this revision.Jul 11 2018, 5:16 PM
Restricted Application added projects: Marble, KDE Edu. · View Herald TranscriptJul 11 2018, 5:16 PM
Restricted Application added subscribers: kde-edu, marble-devel. · View Herald Transcript
mkoller requested review of this revision.Jul 11 2018, 5:16 PM
rahn accepted this revision.Jul 11 2018, 5:59 PM

Looks good (should we switch to the new connect syntax?).

This revision is now accepted and ready to land.Jul 11 2018, 5:59 PM
Closed by commit R34:c4850695c31d: avoid runtime error about unknown signal when compiled without WebKit (authored by mkoller). · Explain WhyJul 12 2018, 6:36 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MPopupItem.cpp (4 lines)

Diff 37581

View Options

PopupItem.cpp

Loading...