Honor ghns KIOSK restriction in new KCMs
ClosedPublic

Authored by broulik on Jul 11 2018, 8:39 AM.

Details

Test Plan

5.13 branch
Put the following in kdeglobals

[KDE Action Restrictions]
ghns=false

and the GHNS buttons were gone. If there are no buttons in the footer, it also fully collapses rather than leaving an empty gap at the bottom which is nice

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jul 11 2018, 8:39 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 11 2018, 8:39 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jul 11 2018, 8:39 AM
davidedmundson added inline comments.
kcms/cursortheme/package/contents/ui/main.qml
147–148

What does kcm.canInstall do?

broulik added inline comments.Jul 11 2018, 9:31 AM
kcms/cursortheme/package/contents/ui/main.qml
147–148
// Disable the install button if we can't install new themes to ~/.icons,
// or Xcursor isn't set up to look for cursor themes there.
if (!m_model->searchPaths().contains(QDir::homePath() + "/.icons") || !iconsIsWritable()) {
    setCanInstall(false);
}
davidedmundson accepted this revision.Jul 11 2018, 9:36 AM
This revision is now accepted and ready to land.Jul 11 2018, 9:36 AM
This revision was automatically updated to reflect the committed changes.