Differential D14036

[wayland] Confine pointer to screen geometry
ClosedPublic
Actions

Authored by zzag on Jul 10 2018, 11:36 PM.

Details

Reviewers
graesslin
Group Reviewers
KWin
Commits
R108:1e4703a71959: [wayland] Confine pointer to screen geometry
Summary

If the new pointer position is "off screen", PointerInputRedirection
just ignores that new position. So, pointer remains on its previous
position. In some particular cases, like reaching default panel, it
degrades desktop experience because one have to slowly move pointer in
order to reach what he/she wants.

This change addresses that problem by confining the new pointer position
to screen geometry.

BUG: 374867
FIXED-IN: 5.13.4

Test Plan

Ran tests

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Jul 10 2018, 11:36 PM
Restricted Application added a project: KWin. · View Herald TranscriptJul 10 2018, 11:36 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Jul 10 2018, 11:36 PM
zzag updated this revision to Diff 37544.Jul 11 2018, 7:47 AM

Setup screen layout in the test

zzag updated this revision to Diff 37546.Jul 11 2018, 8:22 AM

Check startPos

graesslin accepted this revision.Jul 15 2018, 1:40 PM
This revision is now accepted and ready to land.Jul 15 2018, 1:40 PM
zzag added a comment.Jul 15 2018, 3:58 PM

@graesslin Where should it go? Plasma/5.13(and master) or just master?

graesslin added a comment.Jul 15 2018, 7:48 PM
In D14036#292528, @zzag wrote:

@graesslin Where should it go? Plasma/5.13(and master) or just master?

It's a bug fix -> 5.13

zzag edited the summary of this revision. (Show Details)Jul 15 2018, 8:04 PM
Closed by commit R108:1e4703a71959: [wayland] Confine pointer to screen geometry (authored by zzag). · Explain WhyJul 15 2018, 8:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 37830

View Options

autotests/integration/pointer_input.cpp

Loading...
View Options

pointer_input.cpp

Loading...