Add three "safe zone" overlays
ClosedPublic
Actions

Authored by wpessoa on Jul 10 2018, 1:46 AM.

Details

Reviewers

mardelle
alcinos
frdbr

Commits

R158:08e8497ddc8f: Add three "safe zone" overlays

Summary

Merge branch 'refactoring_timeline' of git://anongit.kde.org/kdenlive into feature/adding-new-overlays

I added three "safe zone" overlays. All of them are the first three Farid's (afarid) suggestions:

Center - Adds lines dividing the frame in half vertically and horizontally.

Center Diagonal - Adds lines connecting opposite corners.

Thirds - Adds lines dividing the frame in thirds vertically and horizontally.

Diff Detail

Repository

R158 Kdenlive

Branch

feature/add-new-overlays

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 722
Build 734: arc lint + arc unit

wpessoa requested review of this revision.Jul 10 2018, 1:46 AM

wpessoa created this revision.

Harbormaster completed remote builds in B722: Diff 37490.Jul 10 2018, 1:46 AM

wpessoa edited the summary of this revision. (Show Details)Jul 10 2018, 1:51 AM

wpessoa added a reviewer: frdbr.

Thanks for this contribution and sorry for my late reply. This looks perfect, I will push this to the refactoring branch and check if the configurable layouts can be backported for 18.08.

This revision is now accepted and ready to land.Jul 17 2018, 6:26 AM

Closed by commit R158:08e8497ddc8f: Add three "safe zone" overlays (authored by wpessoa, committed by mardelle). · Explain WhyJul 17 2018, 6:34 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
A	M	src/monitor/view/OverlayCenter.qml (19 lines)
A	M	src/monitor/view/OverlayCenterDiagonal.qml (33 lines)
A	M	src/monitor/view/OverlayThirds.qml (33 lines)
M		src/monitor/view/kdenliveclipmonitor.qml (11 lines)
M		src/monitor/view/kdenlivemonitor.qml (11 lines)
M		src/uiresources.qrc (3 lines)