Differential D13939

Don't ask for passwords in kfilewidgettest
ClosedPublic
Actions

Authored by jtamate on Jul 8 2018, 6:57 AM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R241:aca95c9df958: Don't ask for passwords in kfilewidgettest
Summary

Changed the test to check if the root urls are right for _k_enterUrl.
Can check any schema because the test does not run them.

Test Plan

The test passes with the changes done in https://phabricator.kde.org/D13674, they fail otherwise.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jtamate created this revision.Jul 8 2018, 6:57 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 8 2018, 6:57 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
jtamate requested review of this revision.Jul 8 2018, 6:57 AM
dfaure accepted this revision.Jul 8 2018, 8:45 AM

OK, that's one way. Somewhat obvious (it becomes a test for QUrl API basically), but yeah, KFileWidget doesn't have a mock mechanism for the actual KIO operations.

Thanks.

This revision is now accepted and ready to land.Jul 8 2018, 8:45 AM
Closed by commit R241:aca95c9df958: Don't ask for passwords in kfilewidgettest (authored by jtamate). · Explain WhyJul 8 2018, 8:52 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mautotests/kfilewidgettest.cpp (30 lines)

Diff 37306

View Options

autotests/kfilewidgettest.cpp

Loading...