[Purpose]: use Arc's status colours for the Phab plugin drop-down list (WIP)
ClosedPublic
Actions

Authored by rjvbb on Jul 7 2018, 5:00 PM.

Details

Reviewers

Commits

R495:6d518089aa1c: Prepare to use Arc's status colours in the revision drop-down list

Summary

I'm trying to get the Purpose Phabricator plugin to list the user's open diff. revisions using the same colours as arcanist would use.

I think I've done all the preparations to let the model return the appropriate colour, but it appears it is never asked for this information.

Is it even possible to do this and if so, from what Qt version onwards? (I'm still on Qt 5.9 which doesn't seem to know the textColor property in QML ComboBoxes.)

Test Plan

Builds but doesn't work (yet).

Diff Detail

Repository

R495 Purpose Library

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

rjvbb created this revision.Jul 7 2018, 5:00 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptJul 7 2018, 5:00 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

rjvbb requested review of this revision.Jul 7 2018, 5:00 PM

Harbormaster completed remote builds in B662: Diff 37292.Jul 7 2018, 5:00 PM

LGTM overall.

src/plugins/phabricator/quick/difflistmodel.cpp
87	Why that change?

This revision is now accepted and ready to land.Jul 10 2018, 3:39 PM

Closed by commit R495:6d518089aa1c: Prepare to use Arc's status colours in the revision drop-down list (authored by rjvbb). · Explain WhyJul 10 2018, 6:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/plugins/phabricator/CMakeLists.txt (2 lines)
M			src/plugins/phabricator/phabricatorjobs.h (9 lines)
M			src/plugins/phabricator/phabricatorjobs.cpp (4 lines)
M			src/plugins/phabricator/quick/difflistmodel.h (7 lines)
M			src/plugins/phabricator/quick/difflistmodel.cpp (31 lines)